linux-kernel - RE: [PATCH] drivers/char/hw_random/cctrng.c: Compilation fix.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DB6PR0802MB25339C3460BC71D65B4488DAE9D70@DB6PR0802MB2533.eurprd08.prod.outlook.com>
Date:   Sun, 19 Apr 2020 14:14:03 +0000
From:   Hadar Gat <Hadar.Gat@....com>
To:     "jagdsh.linux@...il.com" <jagdsh.linux@...il.com>,
        "mpm@...enic.com" <mpm@...enic.com>,
        "herbert@...dor.apana.org.au" <herbert@...dor.apana.org.au>,
        "arnd@...db.de" <arnd@...db.de>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:     "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Gilad Ben-Yossef <gilad@...yossef.com>,
        Ofir Drang <Ofir.Drang@....com>, nd <nd@....com>
Subject: RE: [PATCH] drivers/char/hw_random/cctrng.c: Compilation fix.


> From: Jagadeesh Pagadala <jagdsh.linux@...il.com>
> 
> Adding the needed header <linux/fips.h> to fix following compilation error.
> 
> 	CC      drivers/char/hw_random/cctrng.o
> 	drivers/char/hw_random/cctrng.c: In function
> ‘cc_trng_compwork_handler’:
> 	drivers/char/hw_random/cctrng.c:334:49: error: ‘fips_enabled’
> undeclared (first use in this function)
> 	  if (CC_REG_FLD_GET(RNG_ISR, CRNGT_ERR, isr) && fips_enabled) {
> 							 ^
> 	drivers/char/hw_random/cctrng.c:334:49: note: each undeclared
> identifier is reported only once for each function it appears in
> 	drivers/char/hw_random/cctrng.c:335:3: error: implicit declaration of
> function ‘fips_fail_notify’ [-Werror=implicit-function-declaration]
> 	   fips_fail_notify();
> 	   ^
> 	cc1: some warnings being treated as errors
> 	make[4]: *** [drivers/char/hw_random/cctrng.o] Error 1
> 
> Signed-off-by: Jagadeesh Pagadala <jagdsh.linux@...il.com>
> ---
>  drivers/char/hw_random/cctrng.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/char/hw_random/cctrng.c
> b/drivers/char/hw_random/cctrng.c index bdcd562..3124269 100644
> --- a/drivers/char/hw_random/cctrng.c
> +++ b/drivers/char/hw_random/cctrng.c
> @@ -18,6 +18,10 @@
> 
>  #include "cctrng.h"
> 
> +#ifdef CONFIG_CRYPTO_FIPS
> +#include <linux/fips.h>
> +#endif
> +
>  #define CC_REG_LOW(name)  (name ## _BIT_SHIFT)  #define
> CC_REG_HIGH(name) (CC_REG_LOW(name) + name ## _BIT_SIZE - 1)
> #define CC_GENMASK(name)  GENMASK(CC_REG_HIGH(name),
> CC_REG_LOW(name))
> --
> 1.8.3.1

Hi Jagadeesh,
Thanks for your fix but this compilation issue is already fixed.
It was pushed few days ago and is waiting to be applied.
BR,
Hadar