linux-kernel - Re:Re: [PATCH] drm/amdgpu: Remove an unnecessary condition check in reserve_bo_and_cond

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 19 Apr 2020 10:29:17 +0800 (GMT+08:00)
From:   赵军奎 <bernard@...o.com>
To:     Markus Elfring <Markus.Elfring@....de>
Cc:     Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        Felix Kühling <Felix.Kuehling@....com>,
        linux-kernel@...r.kernel.org, opensource.kernel@...o.com,
        Chunming Zhou <David1.Zhou@....com>,
        Daniel Vetter <daniel@...ll.ch>,
        David Airlie <airlied@...ux.ie>
Subject: Re:Re: [PATCH] drm/amdgpu: Remove an unnecessary condition check in reserve_bo_and_cond_vms()





发件人：Markus Elfring <Markus.Elfring@....de>
发送日期：2020-04-19 02:18:06
收件人：Bernard Zhao <bernard@...o.com>,Alex Deucher <alexander.deucher@....com>,"Christian König" <christian.koenig@....com>,amd-gfx@...ts.freedesktop.org,dri-devel@...ts.freedesktop.org
抄送人："Felix Kühling" <Felix.Kuehling@....com>,linux-kernel@...r.kernel.org,opensource.kernel@...o.com,Chunming Zhou <David1.Zhou@....com>,Daniel Vetter <daniel@...ll.ch>,David Airlie <airlied@...ux.ie>
主题：Re: [PATCH] drm/amdgpu: Remove an unnecessary condition check in reserve_bo_and_cond_vms()>> There is no need to if check again,
>
>Thanks for this information.
>
>* Should the function name be mentioned in this change description?
>
>* Would you like to adjust the patch subject?
>
>
>> maybe we could merge into the above else branch.
>
>I suggest to reconsider this wording.
>
>
>…
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
>> @@ -735,10 +735,8 @@ static int reserve_bo_and_cond_vms(struct kgd_mem *mem,
>…
>
>I propose to take further coding style aspects into account.
>https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=90280eaa88ac1a9140dc759941123530d5545bb6#n191
>
>Possible refactoring:
>	if (ret) {
>		pr_err(…);
>		…
>	} else {
>		ctx->reserved = true;
>	}
>
>
>How do you think about to add the tag “Fixes”?
>

Sure, I will modify the code and adjust this patch subject. I will submit it again.

>Regards,
>Markus