[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20200418.201746.783676213458110248.davem@davemloft.net>
Date: Sat, 18 Apr 2020 20:17:46 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: tanhuazhong@...wei.com
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
salil.mehta@...wei.com, yisen.zhuang@...wei.com,
linuxarm@...wei.com, kuba@...nel.org, shenjian15@...wei.com
Subject: Re: [PATCH net-next 01/10] net: hns3: split out
hclge_fd_check_ether_tuple()
From: Huazhong Tan <tanhuazhong@...wei.com>
Date: Sat, 18 Apr 2020 14:47:00 +0800
> +static int hclge_fd_check_spec(struct hclge_dev *hdev,
> + struct ethtool_rx_flow_spec *fs,
> + u32 *unused_tuple)
> +{
> + int ret = 0;
There is no code path that uses 'ret' without it first being
assigned. If I let this code in, then someone is going to
submit a fixup patch removing the initialization.
Powered by blists - more mailing lists