linux-kernel - Re: [PATCH net-next 01/10] net: hns3: split out hclge_fd_check_ether

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d6cdcc43-94a9-318c-fec1-b26b0eb70015@huawei.com>
Date:   Mon, 20 Apr 2020 09:04:48 +0800
From:   tanhuazhong <tanhuazhong@...wei.com>
To:     David Miller <davem@...emloft.net>
CC:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <salil.mehta@...wei.com>, <yisen.zhuang@...wei.com>,
        <linuxarm@...wei.com>, <kuba@...nel.org>, <shenjian15@...wei.com>
Subject: Re: [PATCH net-next 01/10] net: hns3: split out
 hclge_fd_check_ether_tuple()



On 2020/4/19 11:17, David Miller wrote:
> From: Huazhong Tan <tanhuazhong@...wei.com>
> Date: Sat, 18 Apr 2020 14:47:00 +0800
> 
>> +static int hclge_fd_check_spec(struct hclge_dev *hdev,
>> +			       struct ethtool_rx_flow_spec *fs,
>> +			       u32 *unused_tuple)
>> +{
>> +	int ret = 0;
> 
> There is no code path that uses 'ret' without it first being
> assigned.  If I let this code in, then someone is going to
> submit a fixup patch removing the initialization.
> 

Yes, will modify it.
Thanks.

> .
>