linux-kernel - Re:Re: [PATCH] drm/amdgpu: Return more error codes in amdgpu_connector_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AA2AnwCHCIqvuawqjhyAZKo2.3.1587344176120.Hmail.bernard@vivo.com>
Date:   Mon, 20 Apr 2020 08:56:16 +0800 (GMT+08:00)
From:   赵军奎 <bernard@...o.com>
To:     Markus Elfring <Markus.Elfring@....de>
Cc:     amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        Chunming Zhou <David1.Zhou@....com>,
        Andrzej Pietrasiewicz <andrzej.p@...labora.com>,
        Daniel Vetter <daniel@...ll.ch>,
        David Airlie <airlied@...ux.ie>,
        Dhinakaran Pandiyan <dhinakaran.pandiyan@...el.com>,
        José Roberto de Souza <jose.souza@...el.com>,
        Lyude Paul <lyude@...hat.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Sam Ravnborg <sam@...nborg.org>, linux-kernel@...r.kernel.org,
        opensource.kernel@...o.com
Subject: Re:Re: [PATCH] drm/amdgpu: Return more error codes in amdgpu_connector_set_property()



发件人：Markus Elfring <Markus.Elfring@....de>
发送日期：2020-04-19 17:34:47
收件人：Bernard Zhao <bernard@...o.com>,amd-gfx@...ts.freedesktop.org,dri-devel@...ts.freedesktop.org,Alex Deucher <alexander.deucher@....com>,"Christian König" <christian.koenig@....com>,Chunming Zhou <David1.Zhou@....com>
抄送人：Andrzej Pietrasiewicz <andrzej.p@...labora.com>,Daniel Vetter <daniel@...ll.ch>,David Airlie <airlied@...ux.ie>,Dhinakaran Pandiyan <dhinakaran.pandiyan@...el.com>,"José Roberto de Souza" <jose.souza@...el.com>,Lyude Paul <lyude@...hat.com>,Neil Armstrong <narmstrong@...libre.com>,Sam Ravnborg <sam@...nborg.org>,linux-kernel@...r.kernel.org,opensource.kernel@...o.com
主题：Re: [PATCH] drm/amdgpu: Return more error codes in amdgpu_connector_set_property()>> The "if(!encoder)" branch return the same value 0 of the success
>> branch, maybe return -EINVAL is more better.
>
>I suggest to improve the commit message.

Sure.

>
>* Would you like to adjust the patch subject?
>
>* How do you think about to add the tag “Fixes”
>  because of adjustments for the exception handling?

This is a good idea, the code will be more in line with the Linux specifications.
I will adjust this patch commit message and modify the code. I will submit it again.

>
>Regards,
>Markus