linux-kernel - Re: [PATCH] mfd: asic3: Add error checking return in asic3_mfd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200420071339.GG3737@dell>
Date:   Mon, 20 Apr 2020 08:13:39 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Markus Elfring <Markus.Elfring@....de>
Cc:     Tang Bin <tangbin@...s.chinamobile.com>,
        Shengju Zhang <zhangshengju@...s.chinamobile.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: asic3: Add error checking return in
 asic3_mfd_probe()

On Sun, 19 Apr 2020, Markus Elfring wrote:

> > In the function asic3_mfd_probe(), when get resource or irq
> > failed, the value returned just detected and debug error message,
> > but there were no error checking return. So add the right error
> > checking return.
> 
> I suggest to improve the commit message.
> Would you like to adjust the patch subject?
> 
> 
> > And remove the redundant 'ret = 0'.
> 
> I propose to reconsider this interpretation of the source code here.
> How do you think about to move the mentioned statement into an else branch
> at the end?

Could you please fix your mailer.

If you do not, your replies will be lost/discounted!

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog