linux-kernel - Re: [PATCH 1/4] perf cgroup: Avoid needless closing of unopened fd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200420120540.GB14597@kernel.org>
Date:   Mon, 20 Apr 2020 09:05:40 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Tommi Rantala <tommi.t.rantala@...ia.com>,
        Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Namhyung Kim <namhyung@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] perf cgroup: Avoid needless closing of unopened fd

Em Mon, Apr 20, 2020 at 10:48:47AM +0200, Jiri Olsa escreveu:
> On Fri, Apr 17, 2020 at 04:23:26PM +0300, Tommi Rantala wrote:
> > Do not bother with close() if fd is not valid, just to silence valgrind:
> > 
> >     $ valgrind ./perf script
> >     ==59169== Memcheck, a memory error detector
> >     ==59169== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al.
> >     ==59169== Using Valgrind-3.14.0 and LibVEX; rerun with -h for copyright info
> >     ==59169== Command: ./perf script
> >     ==59169==
> >     ==59169== Warning: invalid file descriptor -1 in syscall close()
> >     ==59169== Warning: invalid file descriptor -1 in syscall close()
> >     ==59169== Warning: invalid file descriptor -1 in syscall close()
> >     ==59169== Warning: invalid file descriptor -1 in syscall close()
> >     ==59169== Warning: invalid file descriptor -1 in syscall close()
> >     ==59169== Warning: invalid file descriptor -1 in syscall close()
> >     ==59169== Warning: invalid file descriptor -1 in syscall close()
> >     ==59169== Warning: invalid file descriptor -1 in syscall close()
> > 
> > Signed-off-by: Tommi Rantala <tommi.t.rantala@...ia.com>
> 
> Acked-by: Jiri Olsa <jolsa@...hat.com>

Thanks, applied,

- Arnaldo