linux-kernel - Re: [PATCH 2/4] perf tools: Move zstd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4845b1020dcd05d2927adced7ad5685437af03c2.camel@nokia.com>
Date:   Thu, 23 Apr 2020 05:52:08 +0000
From:   "Rantala, Tommi T. (Nokia - FI/Espoo)" <tommi.t.rantala@...ia.com>
To:     "jolsa@...hat.com" <jolsa@...hat.com>
CC:     "alexander.shishkin@...ux.intel.com" 
        <alexander.shishkin@...ux.intel.com>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "acme@...nel.org" <acme@...nel.org>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "adrian.hunter@...el.com" <adrian.hunter@...el.com>,
        "alexey.budankov@...ux.intel.com" <alexey.budankov@...ux.intel.com>,
        "namhyung@...nel.org" <namhyung@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/4] perf tools: Move zstd_fini() to session deletion

On Mon, 2020-04-20 at 10:54 +0200, Jiri Olsa wrote:
> On Fri, Apr 17, 2020 at 04:23:27PM +0300, Tommi Rantala wrote:
> > Move zstd_fini() call to perf_session__delete(), so that we always
> > cleanup the zstd state when deleting the session.
> 
> it shold be orthogonal with zstd_init calls, which
> are not currently called within perf_session 
> 
> I guess  zstd_initcould moved to perf_session__new,
> just need some nice way to pass rec->opts.comp_level

Makes sense, I'll post v2 later.
-Tommi