linux-kernel - Re: [PATCH 1/4] loop: Use worker per cgroup instead of kworker

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20200421135533.GA9623@dschatzberg-fedora-PC0Y6AEN>
Date:   Tue, 21 Apr 2020 09:55:33 -0400
From:   Dan Schatzberg <schatzberg.dan@...il.com>
To:     Hillf Danton <hdanton@...a.com>
Cc:     Jens Axboe <axboe@...nel.dk>, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH 1/4] loop: Use worker per cgroup instead of kworker

On Tue, Apr 21, 2020 at 10:48:45AM +0800, Hillf Danton wrote:
> 
> On Mon, 20 Apr 2020 18:39:29 -0400 Dan Schatzberg wrote:
> > 
> > @@ -1140,8 +1215,17 @@ static int __loop_clr_fd(struct loop_device *lo, bool release)
> >  	blk_mq_freeze_queue(lo->lo_queue);
> >  
> >  	spin_lock_irq(&lo->lo_lock);
> > +	destroy_workqueue(lo->workqueue);
> 
> Destruct it out of atomic context.

I may as well do this, but it doesn't matter, does it? The
blk_mq_freeze_queue above should drain all I/O so the workqueue will
be idle.