linux-kernel - Re: [PATCH 4/4] loop: Charge i/o to mem and blk cg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20200421135732.GB9623@dschatzberg-fedora-PC0Y6AEN>
Date:   Tue, 21 Apr 2020 09:57:32 -0400
From:   Dan Schatzberg <schatzberg.dan@...il.com>
To:     Hillf Danton <hdanton@...a.com>
Cc:     Jens Axboe <axboe@...nel.dk>, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH 4/4] loop: Charge i/o to mem and blk cg

On Tue, Apr 21, 2020 at 11:33:37AM +0800, Hillf Danton wrote:
> 
> On Mon, 20 Apr 2020 18:39:32 -0400 Dan Schatzberg wrote:
> > 
> > @@ -964,13 +960,16 @@ static void loop_queue_work(struct loop_device *lo, struct loop_cmd *cmd)
> >  	worker = kzalloc(sizeof(struct loop_worker), GFP_NOWAIT | __GFP_NOWARN);
> >  	/*
> >  	 * In the event we cannot allocate a worker, just queue on the
> > -	 * rootcg worker
> > +	 * rootcg worker and issue the I/O as the rootcg
> >  	 */
> > -	if (!worker)
> > +	if (!worker) {
> > +		cmd->blkcg_css = NULL;
> > +		cmd->memcg_css = NULL;
> 
> Dunno if 	css_put(cmd->memcg_css);

Good catch. Need to drop the reference here.