linux-kernel - Re: [PATCH] scsi: BusLogic: remove conversion to bool in blogic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e56ba7e-e072-f7f0-da64-19f10b70f0b8@gonehiking.org>
Date:   Wed, 22 Apr 2020 11:34:52 -0600
From:   Khalid Aziz <khalid@...ehiking.org>
To:     Jason Yan <yanaijie@...wei.com>, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, colin.king@...onical.com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: BusLogic: remove conversion to bool in
 blogic_inquiry()

On 4/20/20 9:41 PM, Jason Yan wrote:
> The '!=' expression itself is bool, no need to convert it to bool again.
> This fixes the following coccicheck warning:
> 
> drivers/scsi/BusLogic.c:2240:46-51: WARNING: conversion to bool not
> needed here
> 
> Signed-off-by: Jason Yan <yanaijie@...wei.com>
> ---
>  drivers/scsi/BusLogic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/BusLogic.c b/drivers/scsi/BusLogic.c
> index b5b3154e2c28..bb49d83cadc7 100644
> --- a/drivers/scsi/BusLogic.c
> +++ b/drivers/scsi/BusLogic.c
> @@ -2237,7 +2237,7 @@ static bool __init blogic_inquiry(struct blogic_adapter *adapter)
>  					"INQUIRE INSTALLED DEVICES ID 0 TO 7");
>  		for (tgt_id = 0; tgt_id < 8; tgt_id++)
>  			adapter->tgt_flags[tgt_id].tgt_exists =
> -				(installed_devs0to7[tgt_id] != 0 ? true : false);
> +				installed_devs0to7[tgt_id] != 0;
>  	}
>  	/*
>  	   Issue the Inquire Setup Information command.
> 

Acked-by: Khalid Aziz <khalid@...ehiking.org>