linux-kernel - Re: [PATCH] scsi: BusLogic: remove conversion to bool in blogic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1v9lodc4x.fsf@oracle.com>
Date:   Fri, 24 Apr 2020 13:30:54 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Jason Yan <yanaijie@...wei.com>
Cc:     <khalid@...ehiking.org>, <jejb@...ux.ibm.com>,
        <martin.petersen@...cle.com>, <colin.king@...onical.com>,
        <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: BusLogic: remove conversion to bool in blogic_inquiry()


Jason,

> The '!=' expression itself is bool, no need to convert it to bool again.
> This fixes the following coccicheck warning:
>
> drivers/scsi/BusLogic.c:2240:46-51: WARNING: conversion to bool not
> needed here

Applied to 5.8/scsi-queue, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering