linux-kernel - RE: [EXT] Re: [PATCH v2 0/5] UFS Host Performance Booster (HPB v1.0) driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN7PR08MB5684489A31196E4490A38DA9DBD20@BN7PR08MB5684.namprd08.prod.outlook.com>
Date:   Wed, 22 Apr 2020 22:09:43 +0000
From:   "Bean Huo (beanhuo)" <beanhuo@...ron.com>
To:     Christoph Hellwig <hch@...radead.org>
CC:     "alim.akhtar@...sung.com" <alim.akhtar@...sung.com>,
        "avri.altman@....com" <avri.altman@....com>,
        "asutoshd@...eaurora.org" <asutoshd@...eaurora.org>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "stanley.chu@...iatek.com" <stanley.chu@...iatek.com>,
        "bvanassche@....org" <bvanassche@....org>,
        "tomas.winkler@...el.com" <tomas.winkler@...el.com>,
        "cang@...eaurora.org" <cang@...eaurora.org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [EXT] Re: [PATCH v2 0/5] UFS Host Performance Booster (HPB v1.0)
 driver

Hi, Christoph
Thanks for your feedback. 

> > To avoid touching the traditional SCSI core, the HPB driver in this
> > series HPB patch chooses to develop under SCSI sub-system layer, and
> > sits the same layer with UFSHCD. At the same time, to minimize changes
> > to UFSHCD driver, the HPB driver submits its HPB READ BUFFER and HPB
> > WRITE BUFFER requests to the scsi
> > device->request_queueu to execute, rather than that directly go
> > device->through
> > raw UPIU request path.
> 
> This feature is completley broken, and rather dangerous due to feeding
> "physical" addresses looked up by the host in.  I do not think we should support
> something that broken in Linux.
>

It Is not plain physical address,  has been encrypted before loading from UFS to
HPB memory, I think we don't worry about its safety.

> Independent of that using two requests in the I/O path is not going to fly either.
> The whole thing seems like an exercise in benchmarketing.

I agree with you. This is my major concern. I have been thinking about HPB implementation in SCSI layer.
That will let SCSI layer manage HPB by calling UFS helper interface. 
If you don't consider UFS HPB is an idiot design,  I want to  change in another version.  Firstly, we really
want to hear your suggestion.
Thanks,

//Bean