linux-kernel - [PATCH 2/2] nfsd4: stid display should preserve on-the-wire byte order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1587674073-9551-2-git-send-email-bfields@redhat.com>
Date:   Thu, 23 Apr 2020 16:34:33 -0400
From:   "J. Bruce Fields" <bfields@...hat.com>
To:     linux-kernel@...r.kernel.org
Cc:     "J. Bruce Fields" <bfields@...hat.com>
Subject: [PATCH 2/2] nfsd4: stid display should preserve on-the-wire byte order

From: "J. Bruce Fields" <bfields@...hat.com>

When we decode the stateid we byte-swap si_generation.

But for simplicity's sake and ease of comparison with network traces,
it's better to display the whole thing in network order.

Reported-by: Scott Mayhew <smayhew@...hat.com>
Signed-off-by: J. Bruce Fields <bfields@...hat.com>
---
 fs/nfsd/nfs4state.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 7537f2f5156e..a6e0a7f77eb0 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -2422,7 +2422,8 @@ static void nfs4_show_owner(struct seq_file *s, struct nfs4_stateowner *oo)

 static void nfs4_show_stateid(struct seq_file *s, stateid_t *stid)
 {
-	seq_printf(s, "0x%16phN", stid);
+	seq_printf(s, "0x%.8x", stid->si_generation);
+	seq_printf(s, "%12phN", &stid->si_opaque);
 }

 static int nfs4_show_open(struct seq_file *s, struct nfs4_stid *st)
-- 
2.25.3