linux-kernel - Re: [PATCH 2/2] nfsd4: stid display should preserve on-the-wire byte order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200423204929.GA11239@pick.fieldses.org>
Date:   Thu, 23 Apr 2020 16:49:29 -0400
From:   "J. Bruce Fields" <bfields@...hat.com>
To:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] nfsd4: stid display should preserve on-the-wire byte
 order

By the way, one other thing I noticed, in the "states" file there's a
field like:

	superblock: "fd:10:114"

That's major:minor:inode number, which is the same thing /proc/locks
uses to identify files.  "superblock" makes sense for the "major:minor"
part, but the inode number is for the one file, not the superblock.  So
that probably should have been

	superblock: "fd:10:114", inode: 114

or something.  Oh well.  It's been that way in a few kernel versions now
so I guess it's not worth breaking backwards compatibility.

--b.