linux-kernel - Re: [PATCH net-next 1/1] net: stmmac: Add option for VLAN filter fail queue enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 23 Apr 2020 15:53:29 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     vee.khee.wong@...el.com
Cc:     peppe.cavallaro@...com, alexandre.torgue@...com,
        joabreu@...opsys.com, mcoquelin.stm32@...il.com,
        netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        boon.leong.ong@...el.com, weifeng.voon@...el.com
Subject: Re: [PATCH net-next 1/1] net: stmmac: Add option for VLAN filter
 fail queue enable

From: Wong Vee Khee <vee.khee.wong@...el.com>
Date: Thu, 23 Apr 2020 15:00:26 +0800

> From: "Chuah, Kim Tatt" <kim.tatt.chuah@...el.com>
> 
> Add option in plat_stmmacenet_data struct to enable VLAN Filter Fail
> Queuing. This option allows packets that fail VLAN filter to be routed
> to a specific Rx queue when Receive All is also set.
> 
> When this option is enabled:
> - Enable VFFQ only when entering promiscuous mode, because Receive All
>   will pass up all rx packets that failed address filtering (similar to
>   promiscuous mode).
> - VLAN-promiscuous mode is never entered to allow rx packet to fail VLAN
>   filters and get routed to selected VFFQ Rx queue.
> 
> Reviewed-by: Voon Weifeng <weifeng.voon@...el.com>
> Reviewed-by: Ong Boon Leong <boon.leong.ong@...el.com>
> Signed-off-by: Chuah, Kim Tatt <kim.tatt.chuah@...el.com>
> Signed-off-by: Ong Boon Leong <boon.leong.ong@...el.com>

Why would you be setting this with a platform attribute?  Even if the
capability exists, wouldn't you want the user to be able to choose
to opt out?