lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 6 May 2020 03:31:00 +0000 From: "Wong, Vee Khee" <vee.khee.wong@...el.com> To: David Miller <davem@...emloft.net>, "joabreu@...opsys.com" <joabreu@...opsys.com> CC: "peppe.cavallaro@...com" <peppe.cavallaro@...com>, "alexandre.torgue@...com" <alexandre.torgue@...com>, "mcoquelin.stm32@...il.com" <mcoquelin.stm32@...il.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-stm32@...md-mailman.stormreply.com" <linux-stm32@...md-mailman.stormreply.com>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "Ong, Boon Leong" <boon.leong.ong@...el.com>, "Voon, Weifeng" <weifeng.voon@...el.com> Subject: RE: [PATCH net-next 1/1] net: stmmac: Add option for VLAN filter fail queue enable > -----Original Message----- > From: netdev-owner@...r.kernel.org <netdev-owner@...r.kernel.org> On > Behalf Of David Miller > Sent: Friday, April 24, 2020 6:53 AM > To: Wong, Vee Khee <vee.khee.wong@...el.com> > Cc: peppe.cavallaro@...com; alexandre.torgue@...com; > joabreu@...opsys.com; mcoquelin.stm32@...il.com; > netdev@...r.kernel.org; linux-stm32@...md-mailman.stormreply.com; > linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; Ong, > Boon Leong <boon.leong.ong@...el.com>; Voon, Weifeng > <weifeng.voon@...el.com> > Subject: Re: [PATCH net-next 1/1] net: stmmac: Add option for VLAN filter fail > queue enable > > From: Wong Vee Khee <vee.khee.wong@...el.com> > Date: Thu, 23 Apr 2020 15:00:26 +0800 > > > From: "Chuah, Kim Tatt" <kim.tatt.chuah@...el.com> > > > > Add option in plat_stmmacenet_data struct to enable VLAN Filter Fail > > Queuing. This option allows packets that fail VLAN filter to be routed > > to a specific Rx queue when Receive All is also set. > > > > When this option is enabled: > > - Enable VFFQ only when entering promiscuous mode, because Receive All > > will pass up all rx packets that failed address filtering (similar to > > promiscuous mode). > > - VLAN-promiscuous mode is never entered to allow rx packet to fail VLAN > > filters and get routed to selected VFFQ Rx queue. > > > > Reviewed-by: Voon Weifeng <weifeng.voon@...el.com> > > Reviewed-by: Ong Boon Leong <boon.leong.ong@...el.com> > > Signed-off-by: Chuah, Kim Tatt <kim.tatt.chuah@...el.com> > > Signed-off-by: Ong Boon Leong <boon.leong.ong@...el.com> > > Why would you be setting this with a platform attribute? Even if the > capability exists, wouldn't you want the user to be able to choose to opt out? Hi Jose/David Miller, 1/ In current implementation, TSN uses VLAN filter that can either accept/reject VLAN-tagged network packets. In some situation, we do not want to drop failed packets, but instead steer the packet to a VLAN Failed Queue Channel. 2/ VLAN Fail Queue Channel will be set to use the RxQ with higheset index as per HW IP configuration because that is the least priority channel. 3/ The way user will enable this feature is through promiscuous mode settings using ifconfig. (e.g. ifconfig enp0s30f4 promisc) 4/ VLAN Filter Fail Packets Queue feature is IP version specific (only applicable to DWMAC5). I would propose we add this under platform data (e.g. dwmac-intel), so that it can be built in according to hardware on a separate patch. Any thoughts?
Powered by blists - more mailing lists