linux-kernel - Re: [PATCH v1] console: fix an issue about ioremap leak.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <c62ec54f-348b-2eae-59eb-374dde4d49ad@web.de>
Date:   Thu, 23 Apr 2020 13:10:14 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Dejin Zheng <zhengdejin5@...il.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org,
        Coccinelle <cocci@...teme.lip6.fr>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Florian Tobias Schandinat <FlorianSchandinat@....de>,
        Ralf Bächle <ralf@...ux-mips.org>,
        Thomas Bogendörfer <tsbogend@...ha.franken.de>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH v1] console: fix an issue about ioremap leak.

> if do_take_over_console() return an error in the newport_probe(),
> due to the io virtual address is not released, it will cause a leak.

How do you think about a wording variant like the following?

   Subject:
   [PATCH v2] console: Complete exception handling in newport_probe()

   Change description:
   A call of the function “do_take_over_console” can fail here.
   The corresponding system resources were not released then.
   Thus add a call of the function “iounmap” together with the check
   of a failure predicate.

I would like to point out that there is a script for the semantic
patch language which would detect other questionable source code.
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/scripts/coccinelle/free/iounmap.cocci

How do you think about to extend presented software analysis approaches?

Regards,
Markus