[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200423142909.GB1562@nuc8i5>
Date: Thu, 23 Apr 2020 22:29:09 +0800
From: Dejin Zheng <zhengdejin5@...il.com>
To: Markus Elfring <Markus.Elfring@....de>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org,
Coccinelle <cocci@...teme.lip6.fr>, linux-kernel@...r.kernel.org,
kernel-janitors@...r.kernel.org,
Andy Shevchenko <andy.shevchenko@...il.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Florian Tobias Schandinat <FlorianSchandinat@....de>,
Ralf Bächle <ralf@...ux-mips.org>,
Thomas Bogendörfer <tsbogend@...ha.franken.de>,
Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH v1] console: fix an issue about ioremap leak.
On Thu, Apr 23, 2020 at 01:10:14PM +0200, Markus Elfring wrote:
> > if do_take_over_console() return an error in the newport_probe(),
> > due to the io virtual address is not released, it will cause a leak.
>
> How do you think about a wording variant like the following?
>
> Subject:
> [PATCH v2] console: Complete exception handling in newport_probe()
>
> Change description:
> A call of the function “do_take_over_console” can fail here.
> The corresponding system resources were not released then.
> Thus add a call of the function “iounmap” together with the check
> of a failure predicate.
>
Thanks!
>
> I would like to point out that there is a script for the semantic
> patch language which would detect other questionable source code.
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/scripts/coccinelle/free/iounmap.cocci
>
> How do you think about to extend presented software analysis approaches?
>
Sorry, I am not familiar with it, I don't know.
BR,
Dejin
> Regards,
> Markus
Powered by blists - more mailing lists