linux-kernel - Re: [PATCH] :ssb sprom.c: Fixed block comments coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 25 Apr 2020 01:05:05 +0200
From:   Michael Büsch <m@...s.ch>
To:     John Oldman <john.oldman@...ehill.co.uk>
Cc:     linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] :ssb sprom.c: Fixed block comments coding style issues

On Fri, 24 Apr 2020 18:50:43 +0100
John Oldman <john.oldman@...ehill.co.uk> wrote:

> Fixed coding style issues
> 
> Signed-off-by: John Oldman <john.oldman@...ehill.co.uk>
> ---
>  drivers/ssb/sprom.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/ssb/sprom.c b/drivers/ssb/sprom.c
> index 52d2e0f33be7..42d620cee8a9 100644
> --- a/drivers/ssb/sprom.c
> +++ b/drivers/ssb/sprom.c
> @@ -78,7 +78,8 @@ ssize_t ssb_attr_sprom_show(struct ssb_bus *bus, char *buf,
>  
>  	/* Use interruptible locking, as the SPROM write might
>  	 * be holding the lock for several seconds. So allow userspace
> -	 * to cancel operation. */
> +	 * to cancel operation.
> +	 */
>  	err = -ERESTARTSYS;
>  	if (mutex_lock_interruptible(&bus->sprom_mutex))
>  		goto out_kfree;
> @@ -121,7 +122,8 @@ ssize_t ssb_attr_sprom_store(struct ssb_bus *bus,
>  
>  	/* Use interruptible locking, as the SPROM write might
>  	 * be holding the lock for several seconds. So allow userspace
> -	 * to cancel operation. */
> +	 * to cancel operation.
> +	 */
>  	err = -ERESTARTSYS;
>  	if (mutex_lock_interruptible(&bus->sprom_mutex))
>  		goto out_kfree;
> @@ -188,9 +190,11 @@ int ssb_fill_sprom_with_fallback(struct ssb_bus *bus, struct ssb_sprom *out)
>  bool ssb_is_sprom_available(struct ssb_bus *bus)
>  {
>  	/* status register only exists on chipcomon rev >= 11 and we need check
> -	   for >= 31 only */
> +	 * for >= 31 only
> +	 */
>  	/* this routine differs from specs as we do not access SPROM directly
> -	   on PCMCIA */
> +	 * on PCMCIA
> +	 */
>  	if (bus->bustype == SSB_BUSTYPE_PCI &&
>  	    bus->chipco.dev &&	/* can be unavailable! */
>  	    bus->chipco.dev->id.revision >= 31)


Acked-by: Michael Büsch <m@...s.ch>

-- 
Michael

Content of type "application/pgp-signature" skipped