linux-kernel - Re: [PATCH net-next v2 6/9] net: phy: add backplane kr driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 24 Apr 2020 15:47:29 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Florinel Iordache <florinel.iordache@....com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, f.fainelli@...il.com,
        hkallweit1@...il.com, linux@...linux.org.uk,
        devicetree@...r.kernel.org, linux-doc@...r.kernel.org,
        robh+dt@...nel.org, mark.rutland@....com, kuba@...nel.org,
        corbet@....net, shawnguo@...nel.org, leoyang.li@....com,
        madalin.bucur@....nxp.com, ioana.ciornei@....com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2 6/9] net: phy: add backplane kr driver support

> +/* Backplane custom logging */
> +#define bpdev_fn(fn)							\
> +void bpdev_##fn(struct phy_device *phydev, char *fmt, ...)		\
> +{									\
> +	struct va_format vaf = {					\
> +		.fmt = fmt,						\
> +	};								\
> +	va_list args;							\
> +	va_start(args, fmt);						\
> +	vaf.va = &args;							\
> +	if (!phydev->attached_dev)					\
> +		dev_##fn(&phydev->mdio.dev, "%pV", &vaf);		\
> +	else								\
> +		dev_##fn(&phydev->mdio.dev, "%s: %pV",			\
> +			netdev_name(phydev->attached_dev), &vaf);	\
> +	va_end(args);							\
> +}
> +
> +bpdev_fn(err)
> +EXPORT_SYMBOL(bpdev_err);
> +
> +bpdev_fn(warn)
> +EXPORT_SYMBOL(bpdev_warn);
> +
> +bpdev_fn(info)
> +EXPORT_SYMBOL(bpdev_info);
> +
> +bpdev_fn(dbg)
> +EXPORT_SYMBOL(bpdev_dbg);

Didn't i say something about just using phydev_{err|warn|info|dbg}?

       Andrew