linux-kernel - Re: [PATCH -next] tracing: Make tracing_snapshot_instance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200424094822.5ae268fb@gandalf.local.home>
Date:   Fri, 24 Apr 2020 09:48:22 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Zou Wei <zou_wei@...wei.com>
Cc:     <mingo@...hat.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] tracing: Make tracing_snapshot_instance_cond()
 static

On Thu, 23 Apr 2020 12:08:25 +0800
Zou Wei <zou_wei@...wei.com> wrote:

> Fix the following sparse warning:
> 
> kernel/trace/trace.c:950:6: warning: symbol 'tracing_snapshot_instance_cond'
> was not declared. Should it be static?

Thanks, I'll add it to my queue.

-- Steve

> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zou Wei <zou_wei@...wei.com>
> ---
>  kernel/trace/trace.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index 8d2b988..1424a89 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -947,7 +947,8 @@ int __trace_bputs(unsigned long ip, const char *str)
>  EXPORT_SYMBOL_GPL(__trace_bputs);
>  
>  #ifdef CONFIG_TRACER_SNAPSHOT
> -void tracing_snapshot_instance_cond(struct trace_array *tr, void *cond_data)
> +static void tracing_snapshot_instance_cond(struct trace_array *tr,
> +					   void *cond_data)
>  {
>  	struct tracer *tracer = tr->current_trace;
>  	unsigned long flags;