linux-kernel - Re: [PATCH v5 5/8] usb: mausb_host: Introduce PAL processing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 26 Apr 2020 14:32:51 +0200
From:   Vladimir Stankovic <vladimir.stankovic@...playlink.com>
To:     Alan Stern <stern@...land.harvard.edu>
Cc:     gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org, mausb-host-devel@...playlink.com
Subject: Re: [PATCH v5 5/8] usb: mausb_host: Introduce PAL processing

On 26.4.20. 02:32, Alan Stern wrote:
> On Sat, 25 Apr 2020 vladimir.stankovic@...playlink.com wrote:
> 
>> Protocol adaptation layer (PAL) implementation has been added to
>> introduce MA-USB structures and logic.
>>
>> Signed-off-by: Vladimir Stankovic <vladimir.stankovic@...playlink.com>
> 
> ...
> 
>> +	/*
>> +	 * Masking URB_SHORT_NOT_OK flag as SCSI driver is adding it where it
>> +	 * should not, so it is breaking the USB drive on the linux
>> +	 */
>> +	urb->transfer_flags &= ~URB_SHORT_NOT_OK;
> 
> Removing the SHORT_NOT_OK flag is _not_ a valid thing to do.  It will 
> cause drivers to malfunction.
> 
> Can you please explain this comment?
> 
> 	What SCSI driver?
> 
> 	When is the flag being added?
> 
> 	How does it break USB drives?
> 
> 	Why haven't you already reported this problem to the 
> 	appropriate maintainers?
> 
> Alan Stern
> 

Hi,

Issue that removal of SHORT_NOT_OK flag addressed is linked to particular
set of Kingston USB 3.0 flash drives (super speed) - other USB flash drives
haven't had this flag set. Without this "fix", those Kingston flash drives
are not being enumerated properly.

This particular line was added in the early stage of development, during
enumeration process implementation. The reason why it remained in the code
since is because we haven't noticed any side-effects, even with various
USB devices being attached to remote MA-USB device, including flash drives,
cameras, wireless mice, etc.

The problem has been reported, and is actively being investigated.

As soon as it gets addressed properly (w/o global negation of the flag),
a new patch will be pushed.

-- 
Regards,
Vladimir.