linux-kernel - Re: [PATCH v5 5/8] usb: mausb_host: Introduce PAL processing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.2004252027360.13475-100000@netrider.rowland.org>
Date:   Sat, 25 Apr 2020 20:32:09 -0400 (EDT)
From:   Alan Stern <stern@...land.harvard.edu>
To:     vladimir.stankovic@...playlink.com
cc:     gregkh@...uxfoundation.org, <linux-kernel@...r.kernel.org>,
        <linux-usb@...r.kernel.org>, <mausb-host-devel@...playlink.com>
Subject: Re: [PATCH v5 5/8] usb: mausb_host: Introduce PAL processing

On Sat, 25 Apr 2020 vladimir.stankovic@...playlink.com wrote:

> Protocol adaptation layer (PAL) implementation has been added to
> introduce MA-USB structures and logic.
> 
> Signed-off-by: Vladimir Stankovic <vladimir.stankovic@...playlink.com>

...

> +	/*
> +	 * Masking URB_SHORT_NOT_OK flag as SCSI driver is adding it where it
> +	 * should not, so it is breaking the USB drive on the linux
> +	 */
> +	urb->transfer_flags &= ~URB_SHORT_NOT_OK;

Removing the SHORT_NOT_OK flag is _not_ a valid thing to do.  It will 
cause drivers to malfunction.

Can you please explain this comment?

	What SCSI driver?

	When is the flag being added?

	How does it break USB drives?

	Why haven't you already reported this problem to the 
	appropriate maintainers?

Alan Stern