lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 26 Apr 2020 22:52:55 -0700 From: Christoph Hellwig <hch@...radead.org> To: Guoqing Jiang <guoqing.jiang@...ud.ionos.com> Cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, hch@...radead.org, david@...morbit.com, willy@...radead.org, Andrew Morton <akpm@...ux-foundation.org>, "Darrick J. Wong" <darrick.wong@...cle.com>, William Kucharski <william.kucharski@...cle.com>, "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>, Andreas Gruenbacher <agruenba@...hat.com>, Yang Shi <yang.shi@...ux.alibaba.com>, Yafang Shao <laoar.shao@...il.com> Subject: Re: [RFC PATCH 1/9] include/linux/pagemap.h: introduce set/clear_fs_page_private Why not attach_page_private and clear_page_private as that conveys the use case a little better? > +static inline void *set_fs_page_private(struct page *page, void *data) > +{ > + get_page(page); > + set_page_private(page, (unsigned long)data); > + SetPagePrivate(page); > + > + return data; > +} > + > +static inline void *clear_fs_page_private(struct page *page) > +{ > + void *data = (void *)page_private(page); > + > + if (!PagePrivate(page)) > + return NULL; > + ClearPagePrivate(page); > + set_page_private(page, 0); > + put_page(page); > + > + return data; > +} Can you add kerneldoc comments describing them, including why we take the refernces? Also what is the point of the return value of set_fs_page_private?
Powered by blists - more mailing lists