linux-kernel - Re: [PATCH] mmc: alcor: Fix a resource leak in an error handling path in 'alcor_pci_sdmmc_drv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <35c7cffb-02dd-452c-f525-fe5ddcbb0a48@web.de>
Date:   Mon, 27 Apr 2020 07:54:33 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Christophe Jaillet <christophe.jaillet@...adoo.fr>,
        linux-mmc@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Colin Ian King <colin.king@...onical.com>,
        Daniel Drake <drake@...lessm.com>,
        Kamlesh Gurudasani <kamlesh.gurudasani@...il.com>,
        Oleksij Rempel <linux@...pel-privat.de>,
        Ulf Hansson <ulf.hansson@...aro.org>
Subject: Re: [PATCH] mmc: alcor: Fix a resource leak in an error handling path
 in 'alcor_pci_sdmmc_drv_probe()'

> If 'devm_request_threaded_irq()' fails, resources allocated by
> 'mmc_alloc_host()' must be freed.

How do you think about a wording variant like the following?

   Subject:
   [PATCH v2] mmc: alcor: Complete exception handling in alcor_pci_sdmmc_drv_probe()

   Change description (according to a solution alternative):
   The exception handling was incomplete in an if branch
   after a failed call of the function “devm_request_threaded_irq”.
   Thus add a call of the function “mmc_free_host” for the release of
   corresponding system resources.


> +++ b/drivers/mmc/host/alcor.c
> @@ -1104,7 +1104,7 @@ static int alcor_pci_sdmmc_drv_probe(struct platform_device *pdev)
>
>  	if (ret) {
>  		dev_err(&pdev->dev, "Failed to get irq for data line\n");
> -		return ret;
> +		goto free_host;
>  	}
>
>  	mutex_init(&host->cmd_mutex);

You propose to perform a jump to other code only once in this implementation.
I find it more succinct to call the desired function then directly.

 		dev_err(…);
+		mmc_free_host(mmc);
 		return ret;


Regards,
Markus