linux-kernel - Re: mmotm 2020-04-26-00-15 uploaded (mm/madvise.c)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200427232851.GC163745@google.com>
Date:   Mon, 27 Apr 2020 16:28:51 -0700
From:   Minchan Kim <minchan@...nel.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     akpm@...ux-foundation.org, broonie@...nel.org,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, linux-next@...r.kernel.org, mhocko@...e.cz,
        mm-commits@...r.kernel.org, sfr@...b.auug.org.au
Subject: Re: mmotm 2020-04-26-00-15 uploaded (mm/madvise.c)

On Sun, Apr 26, 2020 at 10:26:01AM -0700, Randy Dunlap wrote:
> On 4/26/20 12:16 AM, akpm@...ux-foundation.org wrote:
> > The mm-of-the-moment snapshot 2020-04-26-00-15 has been uploaded to
> > 
> >    http://www.ozlabs.org/~akpm/mmotm/
> > 
> > mmotm-readme.txt says
> > 
> > README for mm-of-the-moment:
> > 
> > http://www.ozlabs.org/~akpm/mmotm/
> > 
> > This is a snapshot of my -mm patch queue.  Uploaded at random hopefully
> > more than once a week.
> > 
> > You will need quilt to apply these patches to the latest Linus release (5.x
> > or 5.x-rcY).  The series file is in broken-out.tar.gz and is duplicated in
> > http://ozlabs.org/~akpm/mmotm/series
> > 
> > The file broken-out.tar.gz contains two datestamp files: .DATE and
> > .DATE-yyyy-mm-dd-hh-mm-ss.  Both contain the string yyyy-mm-dd-hh-mm-ss,
> > followed by the base kernel version against which this patch series is to
> > be applied.
> 
> Hi,
> I'm seeing lots of build failures in mm/madvise.c.
> 
> Is Minchin's patch only partially applied or is it just missing some pieces?
> 
> a.  mm/madvise.c needs to #include <linux/uio.h>
> 
> b.  looks like the sys_process_madvise() prototype in <linux/syscalls.h>
> has not been updated:

I screwed up. Sorry about that.
Thanks for the fixing, Randy and Andrew.
> 
> In file included from ../mm/madvise.c:11:0:
> ../include/linux/syscalls.h:239:18: error: conflicting types for ‘sys_process_madvise’
>   asmlinkage long sys##name(__MAP(x,__SC_DECL,__VA_ARGS__)) \
>                   ^
> ../include/linux/syscalls.h:225:2: note: in expansion of macro ‘__SYSCALL_DEFINEx’
>   __SYSCALL_DEFINEx(x, sname, __VA_ARGS__)
>   ^~~~~~~~~~~~~~~~~
> ../include/linux/syscalls.h:219:36: note: in expansion of macro ‘SYSCALL_DEFINEx’
>  #define SYSCALL_DEFINE6(name, ...) SYSCALL_DEFINEx(6, _##name, __VA_ARGS__)
>                                     ^~~~~~~~~~~~~~~
> ../mm/madvise.c:1295:1: note: in expansion of macro ‘SYSCALL_DEFINE6’
>  SYSCALL_DEFINE6(process_madvise, int, which, pid_t, upid,
>  ^~~~~~~~~~~~~~~
> In file included from ../mm/madvise.c:11:0:
> ../include/linux/syscalls.h:880:17: note: previous declaration of ‘sys_process_madvise’ was here
>  asmlinkage long sys_process_madvise(int which, pid_t pid, unsigned long start,
>                  ^~~~~~~~~~~~~~~~~~~
> 
> thanks.
> -- 
> ~Randy
>