linux-kernel - Re: [PATCH 1/3] hwrng: cctrng

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMj1kXFL7e9_=vax0t0YBEzk+hc-d1v0oGVnFO1mfmNPCDaEcQ@mail.gmail.com>
Date:   Mon, 27 Apr 2020 09:24:15 +0200
From:   Ard Biesheuvel <ardb@...nel.org>
To:     Hadar Gat <Hadar.Gat@....com>
Cc:     Matt Mackall <mpm@...enic.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Stefan Wahren <wahrenst@....net>,
        Zaibo Xu <xuzaibo@...wei.com>,
        Tomer Maimon <tmaimon77@...il.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Linux Crypto Mailing List <linux-crypto@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Gilad Ben-Yossef <gilad@...yossef.com>,
        Ofir Drang <Ofir.Drang@....com>, nd <nd@....com>
Subject: Re: [PATCH 1/3] hwrng: cctrng - Add dependency on OF

On Mon, 27 Apr 2020 at 09:23, Hadar Gat <Hadar.Gat@....com> wrote:
>
>
> > -----Original Message-----
> > From: Ard Biesheuvel <ardb@...nel.org>
> >
> > On Mon, 27 Apr 2020 at 07:42, Hadar Gat <hadar.gat@....com> wrote:
> > >
> > > The cctrng is unusable on non-DT systems so we should depend on it.
> > >
> > > Signed-off-by: Hadar Gat <hadar.gat@....com>
> > > ---
> > >  drivers/char/hw_random/Kconfig | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/char/hw_random/Kconfig
> > > b/drivers/char/hw_random/Kconfig index 0c99735..df2d001 100644
> > > --- a/drivers/char/hw_random/Kconfig
> > > +++ b/drivers/char/hw_random/Kconfig
> > > @@ -476,7 +476,7 @@ config HW_RANDOM_KEYSTONE
> > >
> > >  config HW_RANDOM_CCTRNG
> > >         tristate "Arm CryptoCell True Random Number Generator support"
> > > -       depends on HAS_IOMEM
> > > +       depends on HAS_IOMEM & OF
> >
> > Does your driver in fact depend on CONFIG_HAS_IOMEM ?
>
> Yes, it uses devm_ioremap_resource() for registers mapping.
>

Fair enough