linux-kernel - RE: [PATCH 2/3] hwrng: cctrng

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB6PR0802MB25334429B7DD333780E7BABBE9AF0@DB6PR0802MB2533.eurprd08.prod.outlook.com>
Date:   Mon, 27 Apr 2020 07:26:43 +0000
From:   Hadar Gat <Hadar.Gat@....com>
To:     Ard Biesheuvel <ardb@...nel.org>
CC:     Matt Mackall <mpm@...enic.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Stefan Wahren <wahrenst@....net>,
        Zaibo Xu <xuzaibo@...wei.com>,
        Tomer Maimon <tmaimon77@...il.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Linux Crypto Mailing List <linux-crypto@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Gilad Ben-Yossef <gilad@...yossef.com>,
        Ofir Drang <Ofir.Drang@....com>, nd <nd@....com>
Subject: RE: [PATCH 2/3] hwrng: cctrng - change default to n


> -----Original Message-----
> From: Ard Biesheuvel <ardb@...nel.org>
> 
> On Mon, 27 Apr 2020 at 07:42, Hadar Gat <hadar.gat@....com> wrote:
> >
> > For many users, the Arm CryptoCell HW is not available, so the default
> > for HW_RANDOM_CCTRNG changed to n.
> >
> > Signed-off-by: Hadar Gat <hadar.gat@....com>
> > ---
> >  drivers/char/hw_random/Kconfig | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/char/hw_random/Kconfig
> > b/drivers/char/hw_random/Kconfig index df2d001..0938d3d 100644
> > --- a/drivers/char/hw_random/Kconfig
> > +++ b/drivers/char/hw_random/Kconfig
> > @@ -476,8 +476,8 @@ config HW_RANDOM_KEYSTONE
> >
> >  config HW_RANDOM_CCTRNG
> >         tristate "Arm CryptoCell True Random Number Generator support"
> > -       depends on HAS_IOMEM & OF
> > -       default HW_RANDOM
> > +       depends on HW_RANDOM & HAS_IOMEM & OF
> 
> The whole block is guarded by if HW_RANDOM, so I don't think you need the
> dependency here.
> 
> > +       default n
> 
> 'default n' is the default so you can just remove the line

Is this a guideline or just optional?
Personally I like things to be explicit and if allowed I prefer to keep this line.

> 
> >         help
> >           This driver provides support for the True Random Number
> >           Generator available in Arm TrustZone CryptoCell.
> > --
> > 2.7.4
> >