linux-kernel - Re: [PATCH V2 2/3] iio: adc: Add PMIC7 ADC bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5de6ad40-1ce6-6f53-15d8-236f0685a2bb@codeaurora.org>
Date:   Mon, 27 Apr 2020 18:24:43 +0530
From:   Jishnu Prakash <jprakash@...eaurora.org>
To:     Rob Herring <robh@...nel.org>
Cc:     agross@...nel.org, bjorn.andersson@...aro.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        mka@...omium.org, linus.walleij@...aro.org,
        Jonathan.Cameron@...wei.com, smohanad@...eaurora.org,
        kgunda@...eaurora.org, aghayal@...eaurora.org,
        Jonathan Cameron <jic23@...nel.org>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Mark Rutland <mark.rutland@....com>, linux-iio@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, linux-arm-msm-owner@...r.kernel.org
Subject: Re: [PATCH V2 2/3] iio: adc: Add PMIC7 ADC bindings

Hi Rob,

On 4/21/2020 3:32 AM, Rob Herring wrote:
> On Wed, Apr 15, 2020 at 02:47:45PM +0530, Jishnu Prakash wrote:
>>                 of 512 will be used.
>>               - For compatible property "qcom,spmi-adc5", valid values are 250, 420
>>                 and 840. If property is not found, default value of 840 is used.
>> +            - For compatible property "qcom,spmi-adc7", valid values are 85, 340
>> +              and 1360. If property is not found, default value of 1360 is used.
> We express constraints in schema now, don't duplicate with free form
> text.
I'll remove the redundant parts of the descriptions in the next post.
>
>>               - For compatible property "qcom,spmi-adc-rev2", valid values are 256,
>>                 512 and 1024. If property is not present, default value is 1024.
>> +    then:
>> +      patternProperties:
>> +        "^.*@[0-9a-fx]+$":
> 'x' should not be in unit-addresses.
I'll remove it in the next post.
>
>> +          properties:
>> +            qcom,decimation:
>> +              items:
> Not an array, so 'items' doesn't make sense here.
I'll remove it in the next post.
>
>> +                enum: [ 85, 340, 1360 ]
>> +                default: 1360
>> +
>>