linux-kernel - Re: [PATCH net-next 2/4] net: phy: bcm54140: fix phy_id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2112b565-c025-738d-adce-ee1ec0a4e0d1@gmail.com>
Date:   Tue, 28 Apr 2020 15:31:12 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Michael Walle <michael@...le.cc>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH net-next 2/4] net: phy: bcm54140: fix phy_id_mask

On 4/28/20 2:08 PM, Michael Walle wrote:
> Broadcom defines the bits for this PHY as follows:
>   { oui[24:3], model[6:0], revision[2:0] }
> 
> Thus we have to mask the lower three bits only.
> 
> Fixes: 6937602ed3f9 ("net: phy: add Broadcom BCM54140 support")
> Signed-off-by: Michael Walle <michael@...le.cc>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

> ---
> 
> Please note that although this patch contains a Fixes tag its subject
> contains the net-next tag, because the commit in question is only in
> net-next.

Yes, and this is fine, thanks for doing this!
-- 
Florian