linux-kernel - Re: [PATCH] scripts: gtags_files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20200428070457.GA992660@kroah.com>
Date:   Tue, 28 Apr 2020 09:04:57 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     xujialu <xujialu@...ux.org>
Cc:     corbet@....net, linux-kernel@...r.kernel.org, masahiroy@...nel.org,
        akpm@...ux-foundation.org, mchehab+huawei@...nel.org
Subject: Re: [PATCH] scripts: gtags_files_generator.sh

On Tue, Apr 28, 2020 at 01:35:08PM +0800, xujialu wrote:
> > Yes, please, just do proper email responses, like all the other
> > conversations on the mailing lists :)
> 
> Nice of you :)
> 
> > Perhaps you should read the email client documentation in the kernel
> > tree?
> 
> Also watched your interesting video:
>     <HOWTO - apply a Linux kernel patch to the stable tree>
> 
> > I still don't know what is wrong with 'make gtags'.  If it does not work
> > properly for you, why not fix that up instead of creating something
> > totally new that is not even hooked up to the kernel build system?
> 
> As you suggested, i walk through scripts/tags.sh, and suddenly found
> flag COMPILED_SOURCE, so i throw away my lasted stupid script, and tried
> to improve this 'compiled only' feature, seems much better now.
> 
> And about 'make gtags':
> 1. It picks up so many files, do you think 'all sources' is good for us?

When you modify kernel code, yes, you have to fix it up everywhere, you
can not ignore other architectures or drivers that your machine happens
to not use.

An "average" laptop only runs about 2-3 million lines of code or so, a
small percentage of the 25+ million lines that are in the kernel source
tree.

> 2. Seems gtags does not support source files from parrent directories,
> it gives warnning out of tree (global-6.6.3) or just segmentation fault
> (global-5.7.3) when we 'make gtags O=blabla', cause gtags.files is
> generated in dir 'blabla' but source files are out of dir 'blabla'.

Then fix that as a stand-alone patch please, do not mix it in with other
changes.

thanks,

greg k-h