linux-kernel - Re: [PATCH v2] scripts: scripts/tags.sh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20200428070614.GB992660@kroah.com>
Date:   Tue, 28 Apr 2020 09:06:14 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     xujialu <xujialu@...ux.org>
Cc:     corbet@....net, linux-kernel@...r.kernel.org, masahiroy@...nel.org,
        akpm@...ux-foundation.org, mchehab+huawei@...nel.org
Subject: Re: [PATCH v2] scripts: scripts/tags.sh

On Tue, Apr 28, 2020 at 01:35:09PM +0800, xujialu wrote:
> Update function all_compiled_sources for only compiled source files.

Your subject line needs a lot of work.  Please read the section entitled
"The canonical patch format" in the kernel file,
Documentation/SubmittingPatches for what is needed in order to properly
describe the change.

> 
> Usage:
>   1) COMPILED_SOURCE=1                           make {cscope,gtags}
>   2) COMPILED_SOURCE=1 KBUILD_ABS_SRCTREE=1      make {cscope,gtags}
>   3) COMPILED_SOURCE=1              ./scripts/tags.sh {cscope,gtags}
>   4) COMPILED_SOURCE=1 ABSPWD=$PWD/ ./scripts/tags.sh {cscope,gtags}

And you did not document this somewhere for people to be able to find
out?  Also not good :(

greg k-h