linux-kernel - Re: [PATCH] pinctrl: nomadik: ab8505: remove unused 'gpio50_a_1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZv4W3LVxRqDx2EaqATW7a-dhZeDjzoa2iQu+dDtpkfww@mail.gmail.com>
Date:   Tue, 28 Apr 2020 11:41:53 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Jason Yan <yanaijie@...wei.com>,
        Patrice CHOTARD <patrice.chotard@...com>
Cc:     Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH] pinctrl: nomadik: ab8505: remove unused 'gpio50_a_1_pins'

On Fri, Apr 17, 2020 at 9:08 AM Jason Yan <yanaijie@...wei.com> wrote:

> Fix the following gcc warning:
>
> drivers/pinctrl/nomadik/pinctrl-ab8505.c:137:23: warning:
> ‘gpio50_a_1_pins’ defined but not used [-Wunused-const-variable=]
>  static const unsigned gpio50_a_1_pins[] = { AB8505_PIN_L4 };
>                        ^~~~~~~~~~~~~~~
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Jason Yan <yanaijie@...wei.com>

This should not be deleted, it should be used. I will send an alternative
patch with you as Reported-by.

Yours,
Linus Walleij