[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20200428094032.GA23462@kozik-lap>
Date: Tue, 28 Apr 2020 11:40:32 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jonathan Bakker <xc-racer2@...e.ca>
Cc: tomasz.figa@...il.com, s.nawrocki@...sung.com,
linus.walleij@...aro.org, kgene@...nel.org,
linux-arm-kernel@...ts.infradead.org,
linux-samsung-soc@...r.kernel.org, linux-gpio@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: samsung: Save/restore eint_mask over suspend
for EINT_TYPE GPIOs
On Sat, Apr 25, 2020 at 04:10:46PM -0700, Jonathan Bakker wrote:
> Currently, for EINT_TYPE GPIOs, the CON and FLTCON registers
> are saved and restored over a suspend/resume cycle. However, the
> EINT_MASK registers are not.
>
> On S5PV210 at the very least, these registers are not retained over
> suspend, leading to the interrupts remaining masked upon resume and
> therefore no interrupts being triggered for the device. There should
> be no effect on any SoCs that do retain these registers as theoretically
> we would just be re-writing what was already there.
>
> Signed-off-by: Jonathan Bakker <xc-racer2@...e.ca>
> ---
> drivers/pinctrl/samsung/pinctrl-exynos.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
Exynos4412 (Odroid U3) also did not retain the register values. SD card
detect interrupt should be affected.
Thanks, applied (with CC-stable).
Best regards,
Krzysztof
Powered by blists - more mailing lists