linux-kernel - Re: [PATCH] crypto: caam - fix use after free issue in *_crypt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFH1YnMW8YSyiBg6+A8QxYfroVEZr_KELpXcogPemvM=aNFD0Q@mail.gmail.com>
Date:   Tue, 28 Apr 2020 18:09:48 +0800
From:   Zhenzhong Duan <zhenzhong.duan@...il.com>
To:     Iuliana Prodan <iuliana.prodan@....com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        Horia Geanta <horia.geanta@....com>,
        Aymen Sghaier <aymen.sghaier@....com>,
        "herbert@...dor.apana.org.au" <herbert@...dor.apana.org.au>,
        "davem@...emloft.net" <davem@...emloft.net>
Subject: Re: [PATCH] crypto: caam - fix use after free issue in *_crypt_done

On Tue, Apr 28, 2020 at 3:48 PM Iuliana Prodan <iuliana.prodan@....com> wrote:
>
> On 4/28/2020 8:14 AM, Zhenzhong Duan wrote:
> > In both aead_crypt_done and skcipher_crypt_done, edesc->bklog is
> > referenced after the structure pointed by edesc is freed.
> >
> > Fix them by moving kfree(edesc) to the end of function call.
> >
> > Signed-off-by: Zhenzhong Duan <zhenzhong.duan@...il.com>
>
> These issues were already fixed, and applied on cryptodev, by this
> series: https://patchwork.kernel.org/cover/11476799/

I see, thanks

Zhenzhong