linux-kernel - Re: [PATCH v3] checkpatch: add dedicated checker for 'Fixes:' tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <38e1a926-53a6-bda6-cb07-2614f4c682ba@web.de>
Date:   Tue, 28 Apr 2020 12:52:59 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Wang YanQing <udknight@...il.com>, Joe Perches <joe@...ches.com>,
        Andy Whitcroft <apw@...onical.com>,
        kernel-janitors@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        Alexei Starovoitov <alexei.starovoitov@...il.com>,
        Matteo Croce <mcroce@...hat.com>
Subject: Re: [PATCH v3] checkpatch: add dedicated checker for 'Fixes:' tag

> And there is no 'Fixes:' tag format checker in checkpatch

I have taken another look at corresponding implementation details.
Will programming challenges get any more attention?

> to check the commit id length too,

The mentioned script contains the following information.
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/scripts/checkpatch.pl?id=b240f960afb900e59112ebcfa5a759bb0a85a14e#n2818

# Check for git id commit length and improperly formed commit descriptions

> so let's add dedicated checker to check these conditions for 'Fixes:' tag.

How do you think about to reconsider the usage of the word “checker”
at specific places?

> +		    my $id = '0123456789ab';
> +		    my $orig_desc = "commit description";

* Do you try to extend the existing software analysis approach “GIT_COMMIT_ID”?

* Would you like to avoid the development of duplicate Perl code?

Regards,
Markus