linux-kernel - Re: [PATCH v5 3/8] usb: mausb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200428110710.GC1145239@kroah.com>
Date:   Tue, 28 Apr 2020 13:07:10 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     vladimir.stankovic@...playlink.com
Cc:     linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
        mausb-host-devel@...playlink.com
Subject: Re: [PATCH v5 3/8] usb: mausb_host: HCD initialization

On Sat, Apr 25, 2020 at 11:19:49AM +0200, vladimir.stankovic@...playlink.com wrote:
> +static long mausb_ioctl(struct file *file, unsigned int ioctl_func,
> +			unsigned long ioctl_buffer)
> +{
> +	return 0;
> +}
> +

Why do you have an ioctl that does nothing?  Same for the other
functions that just return "success", if you don't do anything in them,
don't declare them please.

> +int mausb_init_hcd(void)
> +{
> +	int retval;
> +
> +	retval = register_chrdev(0, DEVICE_NAME, &mausb_fops);

But you already have a chardev?  Why use another one?

I don't understand the need for these, it's not obvious at all, please
provide a lot more information on what is going on with these userspace
facing interfaces please.

thanks,

greg k-h