linux-kernel - Re: [PATCH v5 7/8] usb: mausb_host: MA-USB PAL events processing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200428110836.GD1145239@kroah.com>
Date:   Tue, 28 Apr 2020 13:08:36 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     vladimir.stankovic@...playlink.com
Cc:     linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
        mausb-host-devel@...playlink.com
Subject: Re: [PATCH v5 7/8] usb: mausb_host: MA-USB PAL events processing

On Sat, Apr 25, 2020 at 11:19:53AM +0200, vladimir.stankovic@...playlink.com wrote:
> +static int mausb_device_assign_address(struct mausb_device *dev,
> +				       struct mausb_usb_device_ctx *usb_dev_ctx)
> +{
> +	int status =
> +		mausb_setusbdevaddress_event_to_user(dev,
> +						     usb_dev_ctx->dev_handle,
> +						     RESPONSE_TIMEOUT);
> +
> +	mausb_pr_info("dev_handle=%#x, status=%d", usb_dev_ctx->dev_handle,
> +		      status);

When drivers are working properly, they are totally silent.  Please
remove this type of debugging code from the driver entirely, or change
it to be dev_dbg().

Otherwise this really looks like a very noisy driver.

greg k-h