linux-kernel - Re: [PATCH v20 02/17] leds: Add multicolor ID to the color ID list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1166f584-8889-df61-393c-f240b7c3c041@ti.com>
Date:   Tue, 28 Apr 2020 07:02:01 -0500
From:   Dan Murphy <dmurphy@...com>
To:     Pavel Machek <pavel@....cz>
CC:     <jacek.anaszewski@...il.com>, <linux-leds@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v20 02/17] leds: Add multicolor ID to the color ID list

Pavel

On 4/28/20 3:43 AM, Pavel Machek wrote:
> On Mon 2020-04-27 12:12:18, Dan Murphy wrote:
>> Pavel
>>
>> On 4/25/20 2:52 PM, Pavel Machek wrote:
>>> On Thu 2020-04-23 10:55:09, Dan Murphy wrote:
>>>> Add a new color ID that is declared as MULTICOLOR as with the
>>>> multicolor framework declaring a definitive color is not accurate
>>>> as the node can contain multiple colors.
>>>>
>>>> Signed-off-by: Dan Murphy <dmurphy@...com>
>>> Please merge with previous patch, and you can keep reviews.
>> Not sure we should do that.  The previous patches deals directly with the
>> bindings and this is code.
>>
>> I thought the rule was to keep bindings and code separated.
>>
>> It made sense to squash the bindings header patch to the bindings document
>> patch but it does not make sense to squash this patch to the bindings.
>>
>> Please let me know if you want me to proceed with the squash.
> Well, OTOH it seems wrong to have array that is only
> half-initialized... But it is not a big deal.

I will squash it into the previous patch as you asked.  Like you said it 
is not a big deal.

Dan