linux-kernel - Re: [v3] checkpatch: add dedicated checker for 'Fixes:' tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 28 Apr 2020 16:54:13 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Wang YanQing <udknight@...il.com>, Joe Perches <joe@...ches.com>,
        Andy Whitcroft <apw@...onical.com>,
        kernel-janitors@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        Alexei Starovoitov <alexei.starovoitov@...il.com>,
        Matteo Croce <mcroce@...hat.com>
Subject: Re: [v3] checkpatch: add dedicated checker for 'Fixes:' tag

> I guess it is a better perl programming practice that use non-capturing group always

I suggest to reconsider the information “always”.

> when you don't need to use the '$' to access it,

Such an expectation can be fine if alternatives would be specified in
the notation “(?:…)”.

> it will make code a little faster I guess.

I hope this also when such a specification is actually needed.

>> * Would we like to support any other quotation characters around
>>   the commit summary?
>
> I think we don't need now

I propose to reconsider also this view.
How should titles be safely handled if they contain the mentioned
quotation characters?

Can it be that you are used to the application of a specific language
where you should choose between two quotes for specification
of attributes (or text)?

> and people could patch it easily when we need others in future:)

I guess that there are further software development challenges to consider.
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/scripts/checkpatch.pl?id=b240f960afb900e59112ebcfa5a759bb0a85a14e#n2872

Regards,
Markus