linux-kernel - Re: [PATCH 2/3] docs: sysctl/kernel: document ftrace entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200429225656.43aed6f9@heffalump.sk2.org>
Date:   Wed, 29 Apr 2020 22:56:56 +0200
From:   Stephen Kitt <steve@....org>
To:     Jonathan Corbet <corbet@....net>
Cc:     Mauro Carvalho Chehab <mchehab+samsung@...nel.org>,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH 2/3] docs: sysctl/kernel: document ftrace entries

On Tue, 28 Apr 2020 12:41:33 -0600, Jonathan Corbet <corbet@....net> wrote:
> On Thu, 23 Apr 2020 20:36:50 +0200
> Stephen Kitt <steve@....org> wrote:
> > Based on the ftrace documentation, the tp_printk boot parameter
> > documentation, and the implementation in kernel/trace/trace.c.
> > 
> > Signed-off-by: Stephen Kitt <steve@....org>  
> 
> This one could benefit from an ack from Steve (CC'd).  Also one other
> little nit below:

Thanks (and thanks for the review Steve). I’ll follow up with v2 shortly,
fixing the spelling and grammar here:

> > +the console.  This is very useful for capturing traces that lead to
> > +crashes and outputing it to a serial console.

in addition to this:

> > +will stop tracepoints from being sent to printk(), and
> > +
> > +::  
> 
> I would just make that ", and::" and avoid the separate line.

Regards,

Stephen

Content of type "application/pgp-signature" skipped