linux-kernel - Re: [PATCH net-next v2 3/7] net: bcmgenet: move clk_wol management to bcmgenet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <411df968-bcc3-298b-2125-3a90567c8bb2@gmail.com>
Date:   Wed, 29 Apr 2020 14:34:14 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Doug Berger <opendmb@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>
Cc:     bcm-kernel-feedback-list@...adcom.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2 3/7] net: bcmgenet: move clk_wol management to
 bcmgenet_wol

On 4/29/20 1:02 PM, Doug Berger wrote:
> The GENET_POWER_WOL_MAGIC power up and power down code configures
> the device for WoL when suspending and disables the WoL logic when
> resuming. It makes sense that this code should also manage the WoL
> clocking.
> 
> This commit consolidates the logic and moves it earlier in the
> resume sequence.
> 
> Since the clock is now only enabled if WoL is successfully entered
> the wol_active flag is introduced to track that state to keep the
> clock enables and disables balanced in case a suspend is aborted.
> The MPD_EN hardware bit can't be used because it can be cleared
> when the MAC is reset by a deep sleep.
> 
> Signed-off-by: Doug Berger <opendmb@...il.com>

Acked-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian