linux-kernel - Re: [RESEND PATCH v6 1/4] mfd: syscon: Add fwnode_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a4396fb5-a6e7-8739-560d-9f1242a80773@linux.intel.com>
Date:   Wed, 29 Apr 2020 13:11:47 +0800
From:   Dilip Kota <eswara.kota@...ux.intel.com>
To:     Arnd Bergmann <arnd@...db.de>, Lee Jones <lee.jones@...aro.org>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Kishon <kishon@...com>, DTML <devicetree@...r.kernel.org>,
        Rob Herring <robh@...nel.org>,
        Andriy Shevchenko <andriy.shevchenko@...el.com>,
        cheol.yong.kim@...el.com, chuanhua.lei@...ux.intel.com,
        qi-ming.wu@...el.com, yixin.zhu@...el.com
Subject: Re: [RESEND PATCH v6 1/4] mfd: syscon: Add fwnode_to_regmap


On 4/28/2020 6:29 PM, Arnd Bergmann wrote:
> On Tue, Apr 28, 2020 at 12:05 PM Lee Jones <lee.jones@...aro.org> wrote:
>> On Tue, 21 Apr 2020, Dilip Kota wrote:
>>> But, i feel return error for ACPI or oother, looks better because
>>> 'device_node' has fwnode pointer. And provide description
>>> in the header file, mentioning function is success for 'OF' and returns
>>> error for the rest.
>> I don't think this patch adds much to be honest.
>>
>> Better to just do:
>>
>>      device_node_get_regmap(to_of_node(fwnode), false);
>>
>> ... from the call site I think.
> Agreed, or just use the of_node pointer consistently in the driver that uses
> it and avoid the use of the fwnode interface entirely when dealing with a
> modern driver that does not need to support board files any more.
>
>        Arnd
Ok, I will do it in the driver itself and remove the fwnode_to_regmap() 
definition.

Regards,
Dilip