linux-kernel - Re: [f2fs-dev] [PATCH V2] f2fs: Avoid double lock for cp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <433d4ad5-22e5-fd2b-cab3-9752ed0c66fb@codeaurora.org>
Date:   Wed, 29 Apr 2020 10:28:36 +0530
From:   Sayali Lokhande <sayalil@...eaurora.org>
To:     Markus Elfring <Markus.Elfring@....de>,
        linux-f2fs-devel@...ts.sourceforge.net,
        Jaegeuk Kim <jaegeuk@...nel.org>, Chao Yu <yuchao0@...wei.com>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [f2fs-dev] [PATCH V2] f2fs: Avoid double lock for cp_rwsem during
 checkpoint

Hi Markus

On 4/27/2020 4:08 PM, Markus Elfring wrote:
>> … This results in deadlock as
>> iput() tries to hold cp_rwsem, which is already held at the
>> beginning by checkpoint->block_operations().
> Will another imperative wording become helpful besides the provided information
> for this change description?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=6a8b55ed4056ea5559ebe4f6a4b247f627870d4c#n151
>
> Would you like to add the tag “Fixes” because of adjustments
> for the data synchronisation?

I couldn't find any past commit which suits to be added under "Fixes" 
here. Let me know if you have any other comment.

>
> Regards,
> Markus