linux-kernel - Re: [PATCH] mailbox: Fix NULL vs IS_ERR() check in zynqmp_ipi_mbox

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1931070d-77fe-996c-3ce4-5400b1bd72cd@web.de>
Date:   Wed, 29 Apr 2020 11:13:15 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Wei Yongjun <weiyongjun1@...wei.com>,
        linux-arm-kernel@...ts.infradead.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jassi Brar <jassisinghbrar@...il.com>,
        Michal Simek <michal.simek@...inx.com>,
        Wendy Liang <wendy.liang@...inx.com>
Subject: Re: [PATCH] mailbox: Fix NULL vs IS_ERR() check in
 zynqmp_ipi_mbox_probe()

> In case of error, the function devm_ioremap() returns NULL pointer
> not ERR_PTR().

Such information is helpful.


> The IS_ERR() test in the return value check should be replaced with NULL test.

Would you like to convert this description into an imperative wording?

Regards,
Markus