linux-kernel - RE: [PATCH] dpaa2-eth: debugfs: use div64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DB8PR04MB6828071573BDB80739446C38E0AD0@DB8PR04MB6828.eurprd04.prod.outlook.com>
Date:   Wed, 29 Apr 2020 09:18:04 +0000
From:   Ioana Ciornei <ioana.ciornei@....com>
To:     Arnd Bergmann <arnd@...db.de>,
        Ioana Ciocoi Radulescu <ruxandra.radulescu@....com>,
        "David S. Miller" <davem@...emloft.net>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] dpaa2-eth: debugfs: use div64_u64 for division

> Subject: [PATCH] dpaa2-eth: debugfs: use div64_u64 for division
> 
> A plain 64-bit division breaks building on 32-bit architectures:
> 
> ERROR: modpost: "__aeabi_uldivmod"
> [drivers/net/ethernet/freescale/dpaa2/fsl-dpaa2-eth.ko] undefined!
> 
> As this function is not performance critical, just use the external helper instead.
> 
> Fixes: 460fd830dd9d ("dpaa2-eth: add channel stat to debugfs")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Thanks for the patch.
A fix for this was applied some hours ago on the net-next branch.

--
Ioana

> ---
>  drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-debugfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-debugfs.c
> b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-debugfs.c
> index 80291afff3ea..0a31e4268dfb 100644
> --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-debugfs.c
> +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-debugfs.c
> @@ -139,7 +139,7 @@ static int dpaa2_dbg_ch_show(struct seq_file *file, void
> *offset)
>  			   ch->stats.dequeue_portal_busy,
>  			   ch->stats.frames,
>  			   ch->stats.cdan,
> -			   ch->stats.frames / ch->stats.cdan,
> +			   div64_u64(ch->stats.frames, ch->stats.cdan),
>  			   ch->buf_count);
>  	}
> 
> --
> 2.26.0