linux-kernel - Re: [PATCH v2 07/12] mtd: rawnand: stm32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 29 Apr 2020 11:31:07 +0200
From:   Christophe Kerello <christophe.kerello@...com>
To:     Miquel Raynal <miquel.raynal@...tlin.com>
CC:     <richard@....at>, <vigneshr@...com>, <lee.jones@...aro.org>,
        <robh+dt@...nel.org>, <mark.rutland@....com>, <tony@...mide.com>,
        <linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <devicetree@...r.kernel.org>, <marex@...x.de>
Subject: Re: [PATCH v2 07/12] mtd: rawnand: stm32_fmc2: cleanup

Hi Miquèl,

On 4/27/20 8:33 PM, Miquel Raynal wrote:
> Hi Christophe,
> 
> Christophe Kerello <christophe.kerello@...com> wrote on Wed, 15 Apr
> 2020 17:57:31 +0200:
> 
>> This patch renames functions and local variables to be ready to use
>> stm32_fmc2 structure.
>>
>> Signed-off-by: Christophe Kerello <christophe.kerello@...com>
>> ---
> 
>> -static int stm32_fmc2_setup_interface(struct nand_chip *chip, int chipnr,
>> -				      const struct nand_data_interface *conf)
>> +static int stm32_fmc2_nfc_setup_interface(struct nand_chip *chip, int chipnr,
>> +					  const struct nand_data_interface *cf)
> 
> I suppose you s/conf/cf/ because of the 80 chars boundary. In this case
> I don't mind crossing it, I don't think it is better to rename the
> conf parameter for this reason.
> 

Yes, you are right. I have modified it because of 80 chars boundary.
I will keep conf in v3.

>>   {
>>   	const struct nand_sdr_timings *sdrt;
>>   
>> -	sdrt = nand_get_sdr_timings(conf);
>> +	sdrt = nand_get_sdr_timings(cf);
>>   	if (IS_ERR(sdrt))
>>   		return PTR_ERR(sdrt);
>>   
>>   	if (chipnr == NAND_DATA_IFACE_CHECK_ONLY)
>>   		return 0;
>>   
>> -	stm32_fmc2_calc_timings(chip, sdrt);
>> -	stm32_fmc2_timings_init(chip);
>> +	stm32_fmc2_nfc_calc_timings(chip, sdrt);
>> +	stm32_fmc2_nfc_timings_init(chip);
>>   
>>   	return 0;
>>   }
>>   
> 
> [...]
> 
>>   
>> -static struct platform_driver stm32_fmc2_driver = {
>> -	.probe	= stm32_fmc2_probe,
>> -	.remove	= stm32_fmc2_remove,
>> +static struct platform_driver stm32_fmc2_nfc_driver = {
>> +	.probe	= stm32_fmc2_nfc_probe,
>> +	.remove	= stm32_fmc2_nfc_remove,
>>   	.driver	= {
>> -		.name = "stm32_fmc2_nand",
>> -		.of_match_table = stm32_fmc2_match,
>> -		.pm = &stm32_fmc2_pm_ops,
>> +		.name = "stm32_fmc2_nfc",
>> +		.of_match_table = stm32_fmc2_nfc_match,
>> +		.pm = &stm32_fmc2_nfc_pm_ops,
>>   	},
>>   };
>> -module_platform_driver(stm32_fmc2_driver);
>> +module_platform_driver(stm32_fmc2_nfc_driver);
>>   
>> -MODULE_ALIAS("platform:stm32_fmc2_nand");
>> +MODULE_ALIAS("platform:stm32_fmc2_nfc");
>>   MODULE_AUTHOR("Christophe Kerello <christophe.kerello@...com>");
>> -MODULE_DESCRIPTION("STMicroelectronics STM32 FMC2 nand driver");
>> +MODULE_DESCRIPTION("STMicroelectronics STM32 FMC2 nfc driver");
> 
> I would prefer: s/nfc/NFC/ here please.
> 

It will be modified in v3.

Regards,
Christophe Kerello.

>>   MODULE_LICENSE("GPL v2");
> 
> With these two nits,
> 
> Reviewed-by: Miquel Raynal <miquel.raynal@...tlin.com>
> 
> Thanks,
> Miquèl
>