lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 29 Apr 2020 05:04:06 -0700 From: Christoph Hellwig <hch@...radead.org> To: Luis Chamberlain <mcgrof@...nel.org> Cc: Christoph Hellwig <hch@...radead.org>, axboe@...nel.dk, viro@...iv.linux.org.uk, bvanassche@....org, gregkh@...uxfoundation.org, rostedt@...dmis.org, mingo@...hat.com, jack@...e.cz, ming.lei@...hat.com, nstange@...e.de, akpm@...ux-foundation.org, mhocko@...e.com, yukuai3@...wei.com, linux-block@...r.kernel.org, linux-fsdevel@...r.kernel.org, linux-mm@...ck.org, linux-kernel@...r.kernel.org, Omar Sandoval <osandov@...com>, Hannes Reinecke <hare@...e.com>, Michal Hocko <mhocko@...nel.org>, syzbot+603294af2d01acfdd6da@...kaller.appspotmail.com Subject: Re: [PATCH v3 4/6] blktrace: fix debugfs use after free On Wed, Apr 29, 2020 at 12:02:30PM +0000, Luis Chamberlain wrote: > > Err, that function is static and has two callers. > > Yes but that is to make it easier to look for who is creating the > debugfs_dir for either the request_queue or partition. I'll export > blk_debugfs_root and we'll open code all this. No, please not. exported variables are usually a bad idea. Just skip the somewhat pointless trivial static function.
Powered by blists - more mailing lists