linux-kernel - Re: [PATCH v3 4/6] blktrace: fix debugfs use after free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200429122152.GL11244@42.do-not-panic.com>
Date:   Wed, 29 Apr 2020 12:21:52 +0000
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     axboe@...nel.dk, viro@...iv.linux.org.uk, bvanassche@....org,
        gregkh@...uxfoundation.org, rostedt@...dmis.org, mingo@...hat.com,
        jack@...e.cz, ming.lei@...hat.com, nstange@...e.de,
        akpm@...ux-foundation.org, mhocko@...e.com, yukuai3@...wei.com,
        linux-block@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        Omar Sandoval <osandov@...com>,
        Hannes Reinecke <hare@...e.com>,
        Michal Hocko <mhocko@...nel.org>,
        syzbot+603294af2d01acfdd6da@...kaller.appspotmail.com
Subject: Re: [PATCH v3 4/6] blktrace: fix debugfs use after free

On Wed, Apr 29, 2020 at 05:04:06AM -0700, Christoph Hellwig wrote:
> On Wed, Apr 29, 2020 at 12:02:30PM +0000, Luis Chamberlain wrote:
> > > Err, that function is static and has two callers.
> > 
> > Yes but that is to make it easier to look for who is creating the
> > debugfs_dir for either the request_queue or partition. I'll export
> > blk_debugfs_root and we'll open code all this.
> 
> No, please not.  exported variables are usually a bad idea.  Just
> skip the somewhat pointless trivial static function.

Alrighty. It has me thinking we might want to only export those symbols
to a specific namespace. Thoughts, preferences?

BLOCK_GENHD_PRIVATE ?

The scsi-generic driver seems... rather unique, and I'd imagine we'd
want to discourage such concoctions in the future, so proliferations
of these symbols.

  Luis